Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit instance dir for afl-fuzz, needed for afl++ #2206

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Use explicit instance dir for afl-fuzz, needed for afl++ #2206

merged 2 commits into from
Jan 25, 2021

Conversation

inferno-chromium
Copy link
Collaborator

afl++ defaults to -S default now. So, explicitly provide one.

@inferno-chromium
Use explicit instance dir for afl-fuzz, needed for afl++
597f9f7 
afl++ defaults to -S default now. So, explicitly provide one.
@inferno-chromium
Copy link
Collaborator Author

/gcbrun

@google-cla google-cla bot added the cla: yes CLA signed. label Jan 25, 2021
@jonathanmetzman
Copy link
Collaborator

afl++ defaults to -S default now. So, explicitly provide one.

Is there some kind of error this fixes?
I think we need to swap out the afl-fuzz binaries for afl++ ones for this to pass tests.

@inferno-chromium
Copy link
Collaborator Author

/gcbrun

@inferno-chromium
Copy link
Collaborator Author

TBR to unblock bots, and see if we need to revert oss-fuzz commit/it sticks.

@inferno-chromium inferno-chromium merged commit 629054b into master Jan 25, 2021
jonathanmetzman
jonathanmetzman reviewed Jan 26, 2021
View reviewed changes
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanmetzman
Copy link
Collaborator

Isn't this going to break internal ClusterFuzz?

@inferno-chromium
Copy link
Collaborator Author

Isn't this going to break internal ClusterFuzz?

-S is supported by regular afl.

@jonathanmetzman
Copy link
Collaborator

Isn't this going to break internal ClusterFuzz?

-S is supported by regular afl.

Nice!

@inferno-chromium inferno-chromium mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman left review comments

Assignees
No one assigned
Labels
cla: yes CLA signed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inferno-chromium @jonathanmetzman